[PATCH 2/2] macsec_linux: Add support for MACsec hardware offload

[Emeel Hakim]

> -----Original Message-----
> From: Jouni Malinen <j at w1.fi>
> Sent: Tuesday, 21 February 2023 19:50
> To: Emeel Hakim <ehakim at nvidia.com>
> Cc: hostap at lists.infradead.org; sd at queasysnail.net
> Subject: Re: [PATCH 2/2] macsec_linux: Add support for MACsec hardware offload
> 
> External email: Use caution opening links or attachments
> 
> 
> On Tue, Feb 21, 2023 at 06:57:51PM +0200, Jouni Malinen wrote:
> > On Wed, Feb 15, 2023 at 08:01:15AM +0000, Emeel Hakim wrote:
> > > > This uses libnl3 to communicate with the macsec module available
> > > > on Linux. A recent enough version of libnl is needed for the hardware offload
> support.
> >
> > > > diff --git a/src/drivers/driver_macsec_linux.c
> > > > b/src/drivers/driver_macsec_linux.c
> > > > +         rtnl_link_macsec_set_offload(drv->link,
> > > > +                                      drv->offload);
> >
> > This breaks the build for commonly used libnl versions and as such,
> > needs some kind of conditional build option to avoid that. Maybe
> > something based on LIBNL_VER_* unless there is a more convenient option.
> 
> It was actually straightforward to do that with LIBNL_VER_NUM and LIBNL_VER(),
> so I applied these two patches with that conditional build support added.

That’s great Thanks!

> --
> Jouni Malinen                                            PGP id EFC895FA