[PATCH 19/50] AP: Support building basic Multi-Link Element

Otcheretianski, Andrei andrei.otcheretianski at intel.com
Tue Feb 21 04:30:42 PST 2023


> > +		/*
> > +		 * TODO: multi link AP has variable length and can be
> > +		 * long based on the common info and number of per
> > +		 * station profiles. For now use 256.
> > +		 */
> Instead of assuming len as 256 can we determine based on link information
> available

Actually for beacons and probe responses basic ml IE doesn't include per station profiles, so it's quite short and has fixed size. 256 is more than enough here.

> 
> > +		/* STA info length */
> > +		wpabuf_put_u8(buf, fixed_len - 2);
> > +
> > +		wpabuf_put_data(buf, link->local_addr, ETH_ALEN);
> > +
> > +		/* TODO: currently assume same beacon interval */
> We use the first link hapd and use its config/parameters for all the link
> station. Rather can we have a list to identify the partner hapd and update the
> same?
> > +		wpabuf_put_le16(buf, hapd->iconf->beacon_int);

Sure.. It's quite simple 😊. We didn't implement it, as currently the client just doesn't care about this information.

Andrei


More information about the Hostap mailing list