[PATCH 08/50] AP: Add some basic MLD configuration options

[Rameshkumar Sundaram (QUIC)]

> -----Original Message-----
> From: Hostap <hostap-bounces at lists.infradead.org> On Behalf Of Andrei
> Otcheretianski
> Sent: Thursday, February 16, 2023 4:38 AM
> To: hostap at lists.infradead.org
> Cc: Andrei Otcheretianski <andrei.otcheretianski at intel.com>
> Subject: [PATCH 08/50] AP: Add some basic MLD configuration options
> 
> Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski at intel.com>
> ---
>  hostapd/config_file.c | 10 ++++++++++
>  src/ap/ap_config.h    | 17 +++++++++++++++++
>  2 files changed, 27 insertions(+)
> 
> diff --git a/hostapd/config_file.c b/hostapd/config_file.c index
> 76f9cf8311..da13a87a02 100644
> --- a/hostapd/config_file.c
> +++ b/hostapd/config_file.c
> @@ -4744,6 +4744,16 @@ static int hostapd_config_fill(struct
> hostapd_config *conf,
>  		conf->eht_phy_capab.su_beamformee = atoi(pos);
>  	} else if (os_strcmp(buf, "eht_mu_beamformer") == 0) {
>  		conf->eht_phy_capab.mu_beamformer = atoi(pos);
> +	} else if (os_strcmp(buf, "mld_ap") == 0) {
> +		bss->mld_ap = !!atoi(pos);
> +	} else if (os_strcmp(buf, "mld_id") == 0) {
a EHT AP is MLD AP, should we still need an extra config, Also why mld_id is needed as extra config? Can we identify using interface name that all the bss belong to same ML AP
with unique interface name? 
> +		bss->mld_id = atoi(pos);
> +	} else if (os_strcmp(buf, "mld_link_id") == 0) {
Should user care about link id, can we have it generated by hostapd instead based on the interfaces list and freq.
> +		bss->mld_link_id = atoi(pos);
> +	} else if (os_strcmp(buf, "mld_eml_capa") == 0) {
The mld_capa and eml capa should come from the driver/hw right?
> +		bss->mld_eml_capa = atoi(pos);