[PATCH] hostapd: Report error on unknown ACCEPT_ACL/DENY_ACL commands

Jouni Malinen j at w1.fi
Wed Feb 1 08:56:20 PST 2023

On Wed, Jan 04, 2023 at 04:53:50PM +0100, Raphaël Mélotte wrote:
> Currently when using ACCEPT_ACL or DENY_ACL, no error is reported if
> the rest of the command is unknown (e.g. 'ACCEPT_ACL FOOBAR' reports
> 'OK').
> On the other hand, hostapd_cli makes it possible to use 'accept_acl'
> and 'deny_acl' in lowercase, but the rest of the command (i.e. 'SHOW',
> 'ADD_MAC', 'CLEAR', etc) must be in uppercase.
> As a result, the command 'accept_acl clear' could seem valid when
> using hostapd_cli (as it reports 'OK'), while it actually does not do
> anything (because 'clear' must be in uppercase).
> To let users know whether the command really succeeded or not, report
> an error when the command was not understood.
> Note that this is also consistent with the way it is currently
> implemented in wpa_supplicant.

Thanks, applied.
Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list