[PATCH] WNM: Preferred Candidate list with truncated BSS Termination

Jouni Malinen j at w1.fi
Sat Dec 16 08:11:40 PST 2023

On Wed, Dec 13, 2023 at 02:37:41PM +0200, Andrei Otcheretianski wrote:
> The expected result is that the truncated frame is discarded, but since
> the bss termination subelement is optional, the frame is going to be
> discarded only if the BSS Termination Included (bit 3) is set. So by
> changing req_mode from 0x01 to 0x09, bit 3 is set and the frame
> is discarded.

That is not the purpose of this test step.. And in fact, this proposed
change would break the test.

> diff --git a/tests/hwsim/test_wnm.py b/tests/hwsim/test_wnm.py
> @@ -754,7 +754,7 @@ def test_wnm_bss_tm_req(dev, apdev):
>      # Preferred Candidate List with truncated BSS Termination Duration
>      # WNM: Too short BSS termination duration
>      req = bss_tm_req(addr, apdev[0]['bssid'],
> -                     req_mode=0x01, dialog_token=8)
> +                     req_mode=0x09, dialog_token=8)

That "WNM: Too short BSS termination duration" in the comment is a
message from the code path that this test step is trying to hit within
wpa_supplicant for code coverage. The proposed change would make this
not achieve that.

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list