[PATCH 7/7] TWT: Add support to configure TWT of a session using offset in microseconds

[Johannes Berg]

On Tue, 2023-04-25 at 21:33 +0530, Gokul Sivakumar wrote:
> 
> @@ -195,6 +195,8 @@ enum ifx_twt_oper {
>   *
>   * @IFX_VENDOR_ATTR_TWT_PARAM_WAKE_TIME: Target Wake Time.
>   *
> + * @IFX_VENDOR_ATTR_TWT_PARAM_WAKE_TIME_OFFSET: Target Wake Time Offset.
> + *
>   * @IFX_VENDOR_ATTR_TWT_PARAM_MIN_WAKE_DURATION: Nominal Minimum TWT Wake Duration.
>   *
>   * @IFX_VENDOR_ATTR_TWT_PARAM_WAKE_INTVL_EXPONENT: TWT Wake Interval Exponent.
> @@ -238,6 +240,7 @@ enum ifx_vendor_attr_twt_param {
>  	IFX_VENDOR_ATTR_TWT_PARAM_SETUP_CMD_TYPE,
>  	IFX_VENDOR_ATTR_TWT_PARAM_DIALOG_TOKEN,
>  	IFX_VENDOR_ATTR_TWT_PARAM_WAKE_TIME,
> +	IFX_VENDOR_ATTR_TWT_PARAM_WAKE_TIME_OFFSET,
>  	IFX_VENDOR_ATTR_TWT_PARAM_MIN_WAKE_DURATION,
>  	IFX_VENDOR_ATTR_TWT_PARAM_WAKE_INTVL_EXPONENT,
>  	IFX_VENDOR_ATTR_TWT_PARAM_WAKE_INTVL_MANTISSA,

I don't know how you manage this, but ... adding a netlink atribute in
the middle of the existing enum is ... really awful?

johannes