[PATCH] dbus: Fix property DebugShowKeys and DebugTimestamp
Jouni Malinen
j at w1.fi
Fri Sep 16 12:20:56 PDT 2022
On Tue, Jul 05, 2022 at 01:11:28PM +0200, Clemens Famulla-Conrad wrote:
> It is possible to specify -t or -K multiple times. With this the
> value isn't boolean anymore and we hit a assert in libdbus
> function `dbus_message_iter_append_basic()`, which expect 0 or 1
> for DBUS_TYPE_BOOLEAN.
Thanks, applied with a copy-paste bug fixed:
> @@ -927,8 +929,10 @@ dbus_bool_t wpas_dbus_getter_debug_show_keys(
> {
> + dbus_bool_t b = wpa_debug_timestamp ? TRUE : FALSE;
> +
> return wpas_dbus_simple_property_getter(iter, DBUS_TYPE_BOOLEAN,
> - &wpa_debug_show_keys, error);
> + &b, error);
That should clearly have used wpa_debug_show_keys as the source
information here.
--
Jouni Malinen PGP id EFC895FA
More information about the Hostap
mailing list