[PATCH v2 17/17] Add support for parsing MLO connection info from roam+auth event

Jouni Malinen j at w1.fi
Wed Sep 14 20:59:23 PDT 2022


On Thu, Sep 08, 2022 at 08:14:23PM +0530, Veerendranath Jakkam wrote:
> Parse QCA_WLAN_VENDOR_ATTR_ROAM_AUTH_MLO_LINKS in
> QCA_NL80211_VENDOR_SUBCMD_KEY_MGMT_ROAM_AUTH event.

> diff --git a/src/drivers/driver_nl80211_event.c b/src/drivers/driver_nl80211_event.c

>  static void nl80211_parse_mlo_info(struct wpa_driver_nl80211_data *drv,
> +				   enum nl80211_commands cmd,

> +	if (0) {
> +#ifdef CONFIG_DRIVER_NL80211_QCA
> +	} else if (cmd == NL80211_CMD_ROAM) {
> +		nl80211_parse_qca_vendor_mlo_link_info(mlo, mlo_links);
> +#endif /* CONFIG_DRIVER_NL80211_QCA */
> +	} else {
> +		nl80211_parse_mlo_link_info(mlo, mlo_links);
>  	}

What is this trying to do? Why NL80211_CMD_ROAM is mapped to trying to
parse a vendor event? Both NL80211_CMD_CONNECT and NL80211_CMD_ROAM
events might end up here and as such, this is at minimum confusing, if
not completely wrong for the real NL80211_CMD_ROAM event case.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list