[PATCH 03/12] MLD STA: Add support to fetch per-link beacon WPA/RSN/RSNX IEs into wpa_sm

Peer, Ilan ilan.peer at intel.com
Tue Sep 13 00:22:49 PDT 2022


Hi,


> -----Original Message-----
> From: Hostap <hostap-bounces at lists.infradead.org> On Behalf Of
> Veerendranath Jakkam
> Sent: Thursday, August 25, 2022 08:53
> To: hostap at lists.infradead.org
> Cc: quic_vjakkam at quicinc.com
> Subject: [PATCH 03/12] MLD STA: Add support to fetch per-link beacon
> WPA/RSN/RSNX IEs into wpa_sm
> 
> wpa_sm needs per-link beacon RSN and RSNX IEs for MLO KDE validation.
> Thus, Add required APIs to parse and set AP link WPA/RSN/RSNX IEs to
> wpa_sm.
> 

As noted in the previous patch, I think that the RSN/RSNXE elements can be configured during the ML information setup
to the WPA SM, as they should be already be known at this stage (as before the connection setup they should already be
known to derive the common AKM suite, cipher suites etc.).

Regards,

Ilan.

> Signed-off-by: Veerendranath Jakkam <quic_vjakkam at quicinc.com>
> ---
>  src/rsn_supp/wpa.c                            | 103 +++++++++++++-----
>  src/rsn_supp/wpa.h                            |  22 ++--
>  src/rsn_supp/wpa_i.h                          |   8 ++
>  tests/fuzzing/eapol-key-supp/eapol-key-supp.c |   2 +-
>  wpa_supplicant/events.c                       |  66 ++++++++---
>  wpa_supplicant/ibss_rsn.c                     |   4 +-
>  wpa_supplicant/wpa_supplicant.c               |  19 ++--
>  wpa_supplicant/wpas_glue.c                    | 103 +++++++++++++++---
>  8 files changed, 247 insertions(+), 80 deletions(-)
> 
> diff --git a/src/rsn_supp/wpa.c b/src/rsn_supp/wpa.c index
> a28d49225..f3965ca50 100644
> --- a/src/rsn_supp/wpa.c
> +++ b/src/rsn_supp/wpa.c
> @@ -3716,6 +3716,7 @@ int wpa_sm_set_assoc_rsnxe(struct wpa_sm *sm,
> const u8 *ie, size_t len)
>  /**
>   * wpa_sm_set_ap_wpa_ie - Set AP WPA IE from Beacon/ProbeResp
>   * @sm: Pointer to WPA state machine data from wpa_sm_init()
> + * @link_id: MLO link ID to set specific link or -1 to set default
>   * @ie: Pointer to IE data (starting from id)
>   * @len: IE length
>   * Returns: 0 on success, -1 on failure @@ -3723,24 +3724,40 @@ int
> wpa_sm_set_assoc_rsnxe(struct wpa_sm *sm, const u8 *ie, size_t len)
>   * Inform WPA state machine about the WPA IE used in Beacon / Probe
> Response
>   * frame.
>   */
> -int wpa_sm_set_ap_wpa_ie(struct wpa_sm *sm, const u8 *ie, size_t len)
> +int wpa_sm_set_ap_wpa_ie(struct wpa_sm *sm, int link_id, const u8 *ie,
> +			 size_t len)

Not sure it is valid to have WPA elements with MLD. If it is indeed not needed, this change is not needed.

Regards,

Ilan.



More information about the Hostap mailing list