[PATCH] obey CONFIG_DEBUG_NO_STDOUT in wpa_debug.c

Jouni Malinen j at w1.fi
Sun Oct 30 01:36:50 PDT 2022


On Fri, Oct 14, 2022 at 05:25:55PM +0000, Norman Hamer wrote:
> diff --git a/src/utils/wpa_debug.c b/src/utils/wpa_debug.c
> @@ -80,8 +80,10 @@ void wpa_debug_print_timestamp(void)
>  		fprintf(out_file, "%ld.%06u: ", (long) tv.sec,
>  			(unsigned int) tv.usec);
>  #endif /* CONFIG_DEBUG_FILE */
> +#ifndef CONFIG_DEBUG_NO_STDOUT
>  	if (!out_file && !wpa_debug_syslog)
>  		printf("%ld.%06u: ", (long) tv.sec, (unsigned int) tv.usec);
> +#endif /* CONFIG_DEBUG_NO_STDOUT */
>  #endif /* CONFIG_ANDROID_LOG */
>  }

Why would these be needed? Isn't this all within an already existing
#ifndef CONFIG_NO_STDOUT_DEBUG?

And CONFIG_DEBUG_NO_STDOUT is not used anywhere in hostap.git.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list