[PATCH v2 01/17] EHT: Add definitions for STA Control fields of Basic Multi-Link element

[Peer, Ilan]

Hi,

> +/*
> + * STA control field definitions of Per-STA Profile subelement in Basic
> + * Multi-Link element as described in Figure 9-1002n: STA Control field
> format.
> + */
> +#define BASIC_ML_STA_CNTRL0_LINK_ID_SHIFT		0

Use 'BASIC_ML_STA_CTRL0_LINK_ID_SHIFT' to be consistent with other definitions below.

> +#define BASIC_ML_STA_CTRL0_LINK_ID_MASK			0x0F
> +#define BASIC_ML_STA_CTRL0_COMPLETE_PROFILE		0x10
> +#define BASIC_ML_STA_CTRL0_PRES_STA_MAC			0x20
> +#define BASIC_ML_STA_CTRL0_PRES_BEACON_INT		0x40
> +#define BASIC_ML_STA_CTRL0_PRES_TSF_OFFSET		0x80
> +#define BASIC_ML_STA_CTRL1_PRES_DTIM_INFO		0x10
> +#define BASIC_ML_STA_CTRL1_PRES_NSTR_LINK_PAIR		0x20
> +#define BASIC_ML_STA_CTRL1_PRES_NSTR_BITMAP		0x40
> +#define BASIC_ML_STA_CTRL1_PRES_BSS_PARAM_COUNT		0x80
> +

The definitions for CTRL1 seem to be wrong. They all should be shifted right by 4.

Regards,

Ilan.