[PATCH] hostap: Missing flags in RNR IE

[Jouni Malinen]

On Sun, Jul 31, 2022 at 10:40:12AM +0300, shay.bar at celeno.com wrote:
> diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c
> @@ -7464,6 +7464,12 @@ static u8 * hostapd_eid_rnr_iface(struct hostapd_data *hapd,
>  			    reporting_hapd->conf->ssid.short_ssid)
>  				bss_param |= RNR_BSS_PARAM_SAME_SSID;
>  
> +			if (iface->num_bss > 1)
> +				bss_param |= RNR_BSS_PARAM_MULTIPLE_BSSID;

RNR_BSS_PARAM_MULTIPLE_BSSID indicates that "the reported AP is part of
a multiple BSSID set", i.e., this is talking about the Multiple BSSID
mechanism defined in IEEE 802.11 to allow a set of APs to share a single
transmitting BSS. hostapd does not support that, i.e., num_bss > 1
indicates that there are multiple independently transmitting BSSs.

> +			if (i == start)
> +				bss_param |= RNR_BSS_PARAM_TRANSMITTED_BSSID;

Similarly for this bit. hostapd configures all BSSs to be transmitting
their own Beacon frames and as such, I don't think this would be
accurate.

There is a proposed patchset to add support for Multiple BSSID
functionality in the manner that these bits are talking about, but that
has not yet been applied. I'd like to be able to test this first with
mac80211_hwsim before adding the complexity in without being able to
easily test it.

In other words, this patch could be consider later once the referenced
functionality is included.

-- 
Jouni Malinen                                            PGP id EFC895FA