[EXT] [RESEND PATCH] Issue: Non-HE capable interface advertising HE

Jouni Malinen j at w1.fi
Sat Nov 5 07:27:21 PDT 2022


On Thu, Sep 29, 2022 at 10:41:53AM +0000, Deepti Panchal wrote:
> This mail describes the purpose of the attached "hostapd" patch.
> The patch avoids issue when there is mismatch between user's 11ax config and DRV capability
> 
> Behavior (without the patch):
> ==========================
>     Non-HE capable interface advertising HE IEs/Capabilities in Beacon/Probe Response/Association Response frames if "ieee80211ax=1" configuration is used
> 
> Patch Description:
> ================
>     1. The HE capability for an AP iface was read from the driver, but was not used to update the "drv_flags" for the interface
>     2. Change is now added to update the HE capability in the "drv_flags" of the interface
>     3. If the interface does not support HE capability, the "iface->conf->ieee80211ax" flag is set to 0
>     4. Now Beacons/Probe response/Association Response will advertise HE capabilities ONLY if the interface is HE capable

So this would make hostapd ignore what the configuration is trying it to
do? That does not sound correct behavior, i.e., I would have expected
the configuration to be rejected instead of being silently ignored.

In any case, I cannot really consider applying this patch without the
Signed-off-by: line in the commit message as described in the
CONTRIBUTIONS file.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list