[PATCH v2 2/3] P2P: optimize join scan freq

[Jouni Malinen]

On Fri, Dec 16, 2022 at 11:10:01AM -0800, Matthew Wang wrote:
> If the auto GO has been discovered on another interface, optimize scan
> frequency by performing a single channel scan first.

> diff --git a/wpa_supplicant/p2p_supplicant.c b/wpa_supplicant/p2p_supplicant.c
> @@ -6954,6 +6954,11 @@ static int wpas_start_p2p_client(struct wpa_supplicant *wpa_s,
> +	if (params->bssid_set) {
> +		ssid->bssid_set = 1;
> +		os_memcpy(ssid->bssid, params->bssid, ETH_ALEN);
> +	}

This breaks some cases since the BSSID of a group can be changed between
reinvocations. As an example, this breaks the
p2p_device_persistent_group2 mac80211_hwsim test case

> diff --git a/wpa_supplicant/scan.c b/wpa_supplicant/scan.c
> @@ -445,11 +445,36 @@ static void wpa_supplicant_optimize_freqs(
> +			if (bss && !disabled_freq(wpa_s, bss->freq)) {

This is missing something since disable_freq() is a static function in
events.c, i.e., this would not compile without that function being
exported from there.

-- 
Jouni Malinen                                            PGP id EFC895FA