[PATCH v2 07/15] SME: Add support for handling authentication with MLD

Otcheretianski, Andrei andrei.otcheretianski at intel.com
Mon Dec 5 09:32:03 PST 2022


> 
> Can "valid_links" itself be used with non-zero check instead of additional
> variable "mld"?
> 

Right. Fixed it.

> > +			if (neigh_bss) {
> > +				wpa_s->valid_links |= BIT(link_id);
> > +				os_memcpy(wpa_s->links[link_id].bssid,
> > +					  ap_info->data + 1, ETH_ALEN);
> > +				wpa_s->links[link_id].freq =
> > +					neigh_bss->freq;
> we need to add checks for local device capabilities before deciding any
> specific link should be considered for MLO association or not, right?

We check that the device supports MLO in the beginning of the function.
But I think it indeed makes sense to call here wpa_scan_res_match() for each link.

> 
> Thanks,
> 
> Veeru

Thank you, Veeru, for reviewing 😊
Andrei


More information about the Hostap mailing list