[PATCH v2 1/6] Revert "nl80211: Indicate interface up only for the main netdev"

[Oleksandr Savchenko]

Hi,

Shortly, broken processing RTM netlink events in setup with several bss.

Test steps:
for example we have 2 bss for on one band: wlan2_0, wlan1_0.
1.1) initial state
 iw dev
phy#0
        Interface wlan2_1
                ifindex 13
                wdev 0x2
                addr 02:1c:51:7d:98:c0
                ssid D5G2
                type AP
                channel 36 (5180 MHz), width: 160 MHz, center1: 5250 MHz
                txpower 19.00 dBm
        Interface wlan2_0
                ifindex 11
                wdev 0x1
                addr 00:1c:51:7d:98:c2
                ssid D5G
                type AP
                channel 36 (5180 MHz), width: 160 MHz, center1: 5250 MHz
                txpower 19.00 dBm
1.2) ip link
11: wlan2_0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq master br0 state UP qlen 1000
    link/ether 00:1c:51:7d:98:c2 brd ff:ff:ff:ff:ff:ff
13: wlan2_1: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc mq state DOWN qlen 1000
    link/ether 02:1c:51:7d:98:c0 brd ff:ff:ff:ff:ff:ff

2) ifconfig wlan2_1 down
   ifconfig wlan2_1 up
2.1) iw dev
   phy#0
        Interface wlan2_1
                ifindex 13
                wdev 0x2
                addr 02:1c:51:7d:98:c0
                type AP
                txpower 19.00 dBm
        Interface wlan2_0
                ifindex 11
                wdev 0x1
                addr 00:1c:51:7d:98:c2
                ssid D5G
                type AP
                channel 36 (5180 MHz), width: 160 MHz, center1: 5250 MHz
                txpower 19.00 dBm
2.2) ip link
11: wlan2_0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq master br0 state UP qlen 1000
    link/ether 00:1c:51:7d:98:c2 brd ff:ff:ff:ff:ff:ff
13: wlan2_1: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc mq state DOWN qlen 1000
    link/ether 02:1c:51:7d:98:c0 brd ff:ff:ff:ff:ff:ff

You could see that wlan2_1 fell to broken state NO-CARRIER and absent LOWER_UP.
hwsim test for such scenario implemented in patch
`[v2,6/6] tests: hwsim: ap_dynamic: Added test case for VAP restart`

Regards,
Alexander

________________________________________
From: Jouni Malinen <j at w1.fi>
Sent: Saturday, November 26, 2022 19:10
To: Alexander Savchenko
Cc: hostap at lists.infradead.org; Johannes Berg; Viktor Barna; Sergiy Petrov
Subject: Re: [PATCH v2 1/6] Revert "nl80211: Indicate interface up only for the main netdev"

On Tue, Sep 06, 2022 at 07:14:05PM +0300, Alexander Savchenko wrote:
> This reverts commit 8a9950f7b6ebd4f555575f60d7ae7a98cdb73383.
>
> Commit 8a9950f7b breaks the virtual AP mode due to non-main interfaces
> can't receive UP state.

Could you please provide more detail on what exactly is broken and how
that could be reproduced in a test? I don't like the idea of just
reverting earlier commits (patches 1 and 2) without clear description of
how the items fixed in those earlier commits are addressed. Patch 2 is
reverting a commit from seven years ago which seems to imply that there
has not really been that significant an issue if this comes up only
now..

--
Jouni Malinen                                            PGP id EFC895FA

----------

This email has been scanned for spam and viruses by Proofpoint Essentials. Visit the following link to report this email as spam:
https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Feu1.proofpointessentials.com%2Findex01.php%3Fmod_id%3D11%26mod_option%3Dlogitem%26mail_id%3D1669482646-HDbQWPRCwkak%26r_address%3Doleksandr.savchenko%2540celeno.com%26report%3D1&data=05%7C01%7Coleksandr.savchenko.dn%40bp.renesas.com%7C6f5485df693942719c1008dacfd12c9c%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C638050794555686968%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=t86C%2B7JeCwcxz0nE4JBimyLXJcdIQiT7kU6zNyefm20%3D&reserved=0

________________________________
The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any retransmission, dissemination, copying or other use of, or taking of any action in reliance upon this information is prohibited. If you received this in error, please contact the sender and delete the material from any computer. Nothing contained herein shall be deemed as a representation, warranty or a commitment by Celeno. No warranties are expressed or implied, including, but not limited to, any implied warranties of non-infringement, merchantability and fitness for a particular purpose.
________________________________