[PATCH 17/18] MLD STA: Get MLO links channel width information for MLO_SIGNAL_POLL

Jouni Malinen j at w1.fi
Wed Aug 31 13:09:48 PDT 2022


On Thu, Jul 28, 2022 at 07:15:46PM +0530, Veerendranath Jakkam wrote:
> Add support to get all MLO links channel width information for
> MLO_SIGNAL_POLL control interface command.

> diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
> +static int get_links_channel_width(struct nl_msg *msg, void *arg)
...

>  static int nl80211_get_links_channel_width(struct wpa_driver_nl80211_data *drv,
>  					   struct wpa_mlo_signal_info *mlo_sig)
>  {
> -	//TODO: Kernel yet to support fetching link channel width information.
> -	return 0;
> +	struct nl_msg *msg;
> +
> +	msg = nl80211_drv_msg(drv, 0, NL80211_CMD_GET_INTERFACE);
> +	return send_and_recv_msgs(drv, msg, get_links_channel_width, mlo_sig,
> +				  NULL, NULL);
>  }

This should really be merged into the previous patch to address the
comments on it.. There is no point in adding a TODO item and then
resolving it in the same patchset. If you want to keep this part in a
separate patch, just get rid of this function (and the ctrl iface prints
for the relevant information) from that earlier patch and add everything
needed here.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list