[PATCH 12/18] MLD STA: Indicate AP MLD address in CTRL-EVENT-CONNECTED

[Jouni Malinen]

On Thu, Jul 28, 2022 at 07:15:41PM +0530, Veerendranath Jakkam wrote:
> Append AP MLD address to CTRL-EVENT-CONNECTED when current connection
> is MLO connection.

> diff --git a/wpa_supplicant/ctrl_iface.c b/wpa_supplicant/ctrl_iface.c
> @@ -2537,12 +2537,22 @@ static int wpa_supplicant_ctrl_iface_status(struct wpa_supplicant *wpa_s,
> +			char mld_addr[50];
> +
> +			memset(&mld_addr, 0, sizeof(mld_addr));

"os_memset(mld_addr, 0, sizeof(mld_addr));" is the preferred form for
this.

> +				     wpa_s->valid_links ? mld_addr : "");

That check for valid_links seems unnecessary complexity here since
mld_addr is "" by default with that memset..


> diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c
> @@ -985,6 +985,14 @@ void wpa_supplicant_set_state(struct wpa_supplicant *wpa_s,
> +		char mld_addr[50];
> +
> +		memset(&mld_addr, 0, sizeof(mld_addr));

> +			wpa_s->valid_links ? mld_addr : "");

Same here.
 
-- 
Jouni Malinen                                            PGP id EFC895FA