[PATCH v2 10/14] PASN: Add support for comeback flow to the wpa_supplicant

[Peer, Ilan]

Hi,

> -----Original Message-----
> From: Jouni Malinen <j at w1.fi>
> Sent: Tuesday, January 26, 2021 01:01
> To: Peer, Ilan <ilan.peer at intel.com>
> Cc: hostap at lists.infradead.org
> Subject: Re: [PATCH v2 10/14] PASN: Add support for comeback flow to the
> wpa_supplicant
> 
> On Wed, Dec 16, 2020 at 01:01:01PM +0200, Ilan Peer wrote:
> > diff --git a/wpa_supplicant/ctrl_iface.c b/wpa_supplicant/ctrl_iface.c
> > @@ -10506,6 +10508,21 @@ static int wpas_ctrl_iface_pasn_start(struct
> > wpa_supplicant *wpa_s, char *cmd)
> > +		} else if (os_strncmp(token, "comeback=", 9) == 0) {
> > +			comeback_len = os_strlen(token + 9);
> ..
> 
> Could you please clarify why this changes the control interface command
> instead of handling the comeback retry automatically within wpa_supplicant?
> 

As PASN is currently only intended for ranging purposes, it makes sense that if a station
cannot successfully complete PASN negotiation in a timely manner, e.g., the AP is currently
busy, it might prefer to perform PASN with other APs, and not retry PASN with the same
AP again. Thus, I thought that this should be handled by the entity that initiated PASN.

Support for automatic comeback retry can be added, but I think that control interface
should allow the option to not perform an automatic retry internally.

Regards,

Ilan.