[PATCH v2 01/14] PASN: Support PASN with SAE key derivation

[Peer, Ilan]

Hi,

> -----Original Message-----
> From: Jouni Malinen <j at w1.fi>
> Sent: Thursday, January 21, 2021 15:41
> To: Peer, Ilan <ilan.peer at intel.com>
> Cc: hostap at lists.infradead.org
> Subject: Re: [PATCH v2 01/14] PASN: Support PASN with SAE key derivation
> 
> On Wed, Dec 16, 2020 at 01:00:52PM +0200, Ilan Peer wrote:
> > diff --git a/wpa_supplicant/pasn_supplicant.c
> > b/wpa_supplicant/pasn_supplicant.c
> > +static struct wpabuf *wpas_pasn_wd_sae_commit(struct wpa_supplicant
> > +*wpa_s)
> 
> > +	ret = sae_prepare_commit(wpa_s->own_addr, pasn->bssid,
> > +				 (u8 *)password,
> > +				 os_strlen(password), 0,
> > +				 &pasn->sae);
> 
> > +	wpabuf_put_le16(buf, WLAN_AUTH_SAE);
> > +	wpabuf_put_le16(buf, 1);
> > +	wpabuf_put_le16(buf, WLAN_STATUS_SUCCESS);
> 
> This seems to be hardcoded to support SAE only with the old hunting-and-
> pecking mechanism and not allow H2E to be used.. I'd hope that all new use
> cases for SAE would use H2E from the beginning. Is there any particular
> reason for this implementation or need for PASN to work with the old design
> for deriving pwe?

No. The main reason is that the original implementation was done before H2E was introduced.
I never got to the point that I modified the implementation to use H2E when possible.

Regards,

Ilan.