[PATCH v2 08/20] PASN: Add functions to compute PTK, MIC and hash

[Peer, Ilan]

> -----Original Message-----
> From: Jouni Malinen <j at w1.fi>
> Sent: Tuesday, January 19, 2021 00:32
> To: Peer, Ilan <ilan.peer at intel.com>
> Cc: hostap at lists.infradead.org
> Subject: Re: [PATCH v2 08/20] PASN: Add functions to compute PTK, MIC and
> hash
> 
> On Wed, Dec 16, 2020 at 01:00:21PM +0200, Ilan Peer wrote:
> > + * pasn_use_sha384 - Should SHA384 be used or SHA256
> 
> > + * second PASN frame. SHA-256 is used as the hash algorithm, except
> > +for the
> > + * ciphers 00-0F-AC:9 and 00-0F-AC:10 for which SHA-384 is used.
> > + */
> > +static u8 pasn_use_sha384(int akmp, int cipher) {
> > +	return (akmp == WPA_KEY_MGMT_PASN && (cipher ==
> WPA_CIPHER_CCMP_256 ||
> > +					      cipher == WPA_CIPHER_GCMP))
> ||
> > +		wpa_key_mgmt_sha384(akmp);
> > +}
> 
> That WPA_CIPHER_GCMP is the 128-bit variant (00-0F-AC:8), not the 256-bit
> variant (00-AF-AC:9) that is being referenced here, so I'll fix that to match.
> 

Missed this as well 😊

Thanks,

Ilan.