[PATCH] dbus: Add SsidTempDisabled signal

Jouni Malinen j at w1.fi
Fri Feb 26 16:08:15 EST 2021


On Thu, Feb 25, 2021 at 05:38:46PM +0100, Peter Malo wrote:
> diff --git a/doc/dbus.doxygen b/doc/dbus.doxygen
> +      <li>
> +	<h3>SsidTempDisabled ( s : ssid, u : auth_failures, s : reason )</h3>
> +	<p>Information about SSID being temporarily disabled.</p>
> +	<h4>Arguments</h4>
> +	<dl>
> +	  <dt>s : ssid</dt>
> +	  <dd>SSID of the network that has been temp disabled.</dd>
> +	  <dt>u : auth_failures</dt>
> +	  <dd>Number of authentication failures</dd>
> +	  <dt>s : reason</dt>
> +	  <dd>Reason for the disabling of the network e.g., "WRONG_KEY"</dd>
> +	</dl>
> +      </li>

This looks a bit strange.. Why would a D-Bus signal include the SSID?
Shouldn't this instead be identifying the network object that is being
temporarily disabled?

If there is a signal notifying that a network got temporarily disabled,
shouldn't there be a signal to notify that such temporarily disablement
was removed?

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list