Build error after radiotap update

Jouni Malinen j at w1.fi
Sun Feb 21 07:11:06 EST 2021


On Wed, Feb 17, 2021 at 12:53:05AM +0100, Matteo Croce wrote:
> After e6ac26943 ("radiotap: Update radiotap parser")
> I get this build error:

> /usr/bin/ld: build/hostapd/src/drivers/driver_nl80211_monitor.o:src/utils/radiotap.h:42: multiple definition of `__packed'; build/hostapd/src/drivers/driver_nl80211.o:src/utils/radiotap.h:42: first defined here

> I tried to replace __packed with __attribute__ ((__packed__)) and
> although it compiles, I have the following warning:
> 
> ../src/utils/radiotap.c: In function ‘ieee80211_radiotap_iterator_init’:
> ../src/utils/radiotap.c:114:27: warning: taking address of packed member of ‘struct ieee80211_radiotap_header’ may result in an unaligned pointer value [-Waddress-of-packed-member]
>   114 |  iterator->_next_bitmap = &radiotap_header->it_present;

Interestingly, I did not see either of these in any of my normal build
setups.. Anyway, this is now fixed here:
https://w1.fi/cgit/hostap/commit/?id=10502ad59f918072057139a315e4cec84e17629f

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list