[PATCH 1/2] wpa_supplicant: Move `wpa_config_get_line()` into utils
ps at pks.im
Sun Feb 14 05:40:16 EST 2021
On Sun, Feb 14, 2021 at 12:09:21AM +0200, Jouni Malinen wrote:
> On Sun, Feb 07, 2021 at 06:48:31PM +0100, Patrick Steinhardt wrote:
> > The function `wpa_config_get_line()` is used by the wpa_supplicant
> > config file parser in order to retrieve the next non-commend non-blank
> > line. We'll need the same kind of functionality in order to implement
> > the file-based external password backend, so as a preparatory step this
> > commit extracts the function into its own standalone file in the utils
> > package.
> > No functional changes are expected from this commit.
> > diff --git a/src/utils/config.c b/src/utils/config.c
> > @@ -0,0 +1,97 @@
> > +/*
> > + * Configuration parsing
> > + * Copyright (c) 2021, Patrick Steinhardt <ps at pks.im>
> Isn't this just moving existing functionality from
> wpa_supplicant/config_file.c to another file? Changing copyright
> statement for the otherwise unmodified implementation does not sound
Yeah, I wasn't quite sure how to handle it given that it's a new file
with old code. I'll use the old copyright in v2.
> > diff --git a/wpa_supplicant/Makefile b/wpa_supplicant/Makefile
> This would need matching changes in wpa_supplicant/Android.mk to avoid
> breaking Android builds. And actually also in wpa_supplicant/nmake.mak
> and wpa_supplicant/vs2005/*/*.vcproj.
Thanks, I wasn't aware.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: not available
More information about the Hostap