[PATCH] wpa_supplicant: multi_ap: only enable 4addr mode if not already enabled

[Raphaël Mélotte]

On 2/10/21 10:38 AM, Jouni Malinen wrote:
> On Wed, Feb 10, 2021 at 10:07:42AM +0100, Janusz Dziedzic wrote:
>> wt., 9 lut 2021 o 10:26 Janusz Dziedzic <janusz.dziedzic at gmail.com> napisał(a):
>>> pon., 8 lut 2021 o 18:30 Raphaël Mélotte <raphael.melotte at mind.be> napisał(a):
>>>> If 4addr mode is already enabled, the call to enable it a second time
>>>> may fail. If this happens when roaming, it leads to deauthentication.
> 
> What is the case where 4ddr mode would have already been enabled? Does
> this happen every time when there is roaming since
> multi_ap_set_4addr_mode() did not have this check before? Or are you
> considering cases where something external to wpa_supplicant is changing
> this parameter?

In my specific case I think 4addr mode is always enabled (by the supplicant) 
before roaming, because I'm trying to switch from one backhaul AP to another one 
(which means the supplicant enables 4addr mode when connecting to the first bAP).

As Janusz pointed out, it seems the actual problem I'm facing is not the fact 
that 4addr mode is already enabled, but the fact that the interface is already 
part of the bridge (so my patch description is not accurate). No external entity 
changes this parameter in my case.


Thanks,

Raphaël