[PATCH] More consistent help command in wpa_cli
j at w1.fi
Sun Oct 11 13:21:16 EDT 2020
On Mon, Aug 10, 2020 at 04:06:27AM +0000, akater wrote:
> I'm writing an interface for wpa_cli that parses its internal help page
> during use. Some docstrings are not separated from corresponding
> commands and its arguments with equality sign like others. This fixes
I'm not sure I'd consider wpa_cli help output as something that would be
suitable for automatic parsing. That format is subject to change without
notice and may break such uses.
> I also capitalized all docstrings. Some were capitalized; some were
> not. I found that e.g.
> ... clear = Clear ...
> looks better and more consistent than
> ... clear = clear ...
> I also replaced all “sends”, “reports” with imperative “Send”, “Report”,
> It is likely that hostapd_cli.c needs very similar patch but I'm not
> using it. I'll likely patch it later if this patch gets merged.
> diff --git a/wpa_supplicant/wpa_cli.c b/wpa_supplicant/wpa_cli.c
Even though I'm not promoting automatic parsing of this, the proposed
changes here seem to be reasonable. However, I would need to get a patch
with the Signed-off-by: line in the commit message as described in the
CONTRIBUTIONS file before I can consider applying this.
Jouni Malinen PGP id EFC895FA
More information about the Hostap