[PATCH v6 03/17] Driver: Add key_type and Extended Key ID driver flag

Jouni Malinen j at w1.fi
Fri Sep 20 06:01:04 PDT 2019


On Sun, Sep 15, 2019 at 10:08:23PM +0200, Alexander Wetzel wrote:
> Add the new driver flag WPA_DRIVER_FLAGS_EXTENDED_KEY_ID and the key
> type attribute key_type. The later will be used in other patches to
> replace the boolean set_tx with something also able to handle Extended
> Key ID.

> diff --git a/src/common/wpa_common.h b/src/common/wpa_common.h
> +enum key_type {
> +	KEY_TYPE_BROADCAST,
> +	KEY_TYPE_DEFAULT,
> +	KEY_TYPE_PAIRWISE,
> +	KEY_TYPE_NO_AUTO_TX,
> +	KEY_TYPE_SET_TX,
> +};

I'm moving this into src/common/defs.h since this is internal defines
instead of specific to some external standard. Furthermore, I'm moving
this into patch 4/17 which is the first place where enum key type is
actually used.

> diff --git a/src/drivers/driver.h b/src/drivers/driver.h
> +/** Driver supports Extended Key ID */
> +#define WPA_DRIVER_FLAGS_EXTENDED_KEY_ID	0x0400000000000000ULL

This is a bit silly on its own as a commit (i.e., this is the only thing
remaining of patch 3/17 after the changes described here), but I guess
that might be the cleanest option here since patch 10/17 is the first
user of this and doing that before patch 15/17 would depend on the value
getting defined before the end of the series.

>  #define FULL_AP_CLIENT_STATE_SUPP(drv_flags) \
> @@ -2305,6 +2307,23 @@ struct wpa_driver_ops {
> +	 * @key_type: Additional instructions for key install:
..

And all these move into patch 4/17 where the new argument to the
callback function is actually added.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list