[PATCH v6 09/17] nl80211,wpa_supplicant: Drop outdated tdls hack

Jouni Malinen j at w1.fi
Fri Sep 20 03:03:45 PDT 2019


On Sun, Sep 15, 2019 at 10:08:29PM +0200, Alexander Wetzel wrote:
> wpa_tdls_set_key() did set key_id to -1 as a signal to handle the key
> install a bit different than for other pairwise keys.
> 
> Since we cleaned up the key install logic with a previous patch this is
> no longer needed and can be removed.
> 
> Signed-off-by: Alexander Wetzel <alexander at wetzel-home.de>
> ---
> 
> The workaround cleaned up here is not limited to nl80211, so I put it
> into a separate patch. It just finalizes the nl80211 driver key install
> cleanup without breaking anything in between.

This key_id == -1 case is used by an old out-of-tree driver wrapper to
make TDLS work. In other words, this commit would break that. Not that
I'm too worried about out-of-tree code, but I'd like to understand what
exactly this patch is trying to achieve. Is this just cleanup and as
such, could it be dropped without breaking anything in this patch
series?

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list