[PATCH v5 10/16] wpa_supplicant: AP Extended Key ID support

Alexander Wetzel alexander at wetzel-home.de
Tue Sep 10 10:23:53 PDT 2019


Am 2019-08-25 um 18:35 schrieb Alexander Wetzel:
> This also fixes an off by one error for key tracking and deletion:
> 
> Even within IEEE 802.11w the highest keyid is 5 and not 6.
> 

No, that's plain wrong and the promised fix is a bug.
The loop processing the variable max reads:
         for (i = 0; i < max; i++) {

Therefore max=6 is correct when we support iGTKs and max=4 is ok when not.

So this part of the patch has now been reverted in my local git:
> --- a/wpa_supplicant/wpa_supplicant.c
> +++ b/wpa_supplicant/wpa_supplicant.c
> @@ -699,7 +699,7 @@ void wpa_clear_keys(struct wpa_supplicant *wpa_s, const u8 *addr)
>   	int i, max;
>   
>   #ifdef CONFIG_IEEE80211W
> -	max = 6;
> +	max = 5;
>   #else /* CONFIG_IEEE80211W */
>   	max = 4;
>   #endif /* CONFIG_IEEE80211W */

I've also made some other minor changes but these were all cosmetic... 
If there is no immediate interest I would again wait a few days (maybe a 
week) prior sending the updated patch series out again for more issues 
to address.

Alexander



More information about the Hostap mailing list