[PATCH 2/2] Add 802.11 status code strings

Brian Norris briannorris at chromium.org
Wed Apr 17 18:00:05 PDT 2019


Hi Alex,

Thanks for the patch. I noted elsewhere, but I'll note here too so
anyone looking here is aware.

On Mon, Apr 15, 2019 at 12:20:06PM -0700, akhouderchah at chromium.org wrote:
> diff --git a/wpa_supplicant/events.c b/wpa_supplicant/events.c
> index 0baef0fe2..71b107483 100644
> --- a/wpa_supplicant/events.c
> +++ b/wpa_supplicant/events.c
> @@ -4246,8 +4246,9 @@ void wpa_supplicant_event(void *ctx, enum wpa_event_type event,
>  			wpa_supplicant_event_assoc_auth(wpa_s, data);
>  		if (data) {
>  			wpa_msg(wpa_s, MSG_INFO,
> -				WPA_EVENT_SUBNET_STATUS_UPDATE "status=%u",
> -				data->assoc_info.subnet_status);
> +				WPA_EVENT_SUBNET_STATUS_UPDATE "status=%u (%s)",
> +				data->assoc_info.subnet_status,
> +				status2str(data->assoc_info.subnet_status));

If I'm reading correctly, this status field is not using WLAN_STATUS_*
codes:
                /**
                 * subnet_status - The subnet status:
                 * 0 = unknown, 1 = unchanged, 2 = changed
                 */
                u8 subnet_status;

Otherwise, this patch looks good to me:

Reviewed-by: Brian Norris <briannorris at chromium.org>

>  		}
>  		break;
>  	case EVENT_DISASSOC:



More information about the Hostap mailing list