[PATCH] EAP: Remove unreachable code in EAP auth SM

Otcheretianski, Andrei andrei.otcheretianski at intel.com
Sun Apr 7 00:36:29 PDT 2019


> On Wed, Apr 03, 2019 at 03:16:12PM +0300, Andrei Otcheretianski wrote:
> > diff --git a/src/ap/wpa_auth.c b/src/ap/wpa_auth.c @@ -3302,16 +3302,9
> > @@ SM_STATE(WPA_PTK, PTKINITDONE)
> 
> > -	if (0 /* IBSS == TRUE */) {
> > -		sm->keycount++;
> > -		if (sm->keycount == 2) {
> > -			wpa_auth_set_eapol(sm->wpa_auth, sm->addr,
> > -					   WPA_EAPOL_portValid, 1);
> > -		}
> > -	} else {
> > -		wpa_auth_set_eapol(sm->wpa_auth, sm->addr,
> WPA_EAPOL_portValid,
> > -				   1);
> > -	}
> > +	wpa_auth_set_eapol(sm->wpa_auth, sm->addr, WPA_EAPOL_portValid,
> > +			   1);
> > +
> 
> Why? That IBSS case is documented there for purpose as a reminder for
> eventually completing that behavior as defined in the standard.
Hi Jouni,

Thinks for a quick reply to our patches..
Some static code analyzers warn about unreachable code.
This code is untouched for more than 10 years, so I assumed nobody will ever get to it anyway :)
Personally I think it's better to replace it with a "TODO" comment rather than keeping dead code.
But, it's completely matter of taste - you can drop this patch if you want.

Andrei
> 
> --
> Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list