[PATCH] bgscan: Add centralized signal_monitor

Jouni Malinen j at w1.fi
Sat Apr 6 07:22:51 PDT 2019

On Thu, Mar 28, 2019 at 01:44:09PM -0700, npoojary at chromium.org wrote:
> From: Paul Stewart <pstew at chromium.org>
> The signal strength number tells only half of the picture with
> respect to signal quality.  The other half is the prevailing
> noise on the channel.  The two together indicate how easily the
> interface is able to pull data out of the background noise.
> This change takes noise into account, by calculating a CQM
> threshold based both on the RSSI and noise.  This noise value is
> available in the CQM events as well as polled data.  Since most
> background scan algorithms will probably want to do this the same
> way, I have added this as routines in bgscan.c that can be
> utilized by individual background scan mechanisms.
> Additionally, I've modified bgscan_simple to use this mechanism,
> and scheduled noisefloor updates to happen at the same rate as
> background scans (the noisefloor should be a slowly changing
> parameter).
> This patch also includes changes to the background scan procedure
> to make background scans low priority and resume aborted scans from 
> frequencies that haven't been scanned yet.
> ---

Could you please read the top level CONTRIBUTIONS file and resubmit this
patch with the Signed-off-by: line added to the end of the commit
message so that I could consider applying this?

In addition, I cannot accept this old license statement:

> diff --git a/wpa_supplicant/bgscan_i.h b/wpa_supplicant/bgscan_i.h
> new file mode 100644
> index 000000000..39ffdc48e
> --- /dev/null
> +++ b/wpa_supplicant/bgscan_i.h
> @@ -0,0 +1,72 @@
> +/*
> + * WPA Supplicant - background scan and roaming interface
> + * Copyright (c) 2009-2010, Jouni Malinen <j at w1.fi>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * Alternatively, this software may be distributed under the terms of BSD
> + * license.
> + *
> + * See README and COPYING for more details.
> + */

hostap.git does not use GPLv2 and I won't be adding any GPL licensed
code into the repository. Could you please use the current license terms
used in other files, i.e., only the BSD license?

 * This software may be distributed under the terms of the BSD license.
 * See README for more details.

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list