[PATCH] EAP: Remove unreachable code in EAP auth SM

Jouni Malinen j at w1.fi
Sat Apr 6 06:52:53 PDT 2019


On Wed, Apr 03, 2019 at 03:16:12PM +0300, Andrei Otcheretianski wrote:
> diff --git a/src/ap/wpa_auth.c b/src/ap/wpa_auth.c
> @@ -3302,16 +3302,9 @@ SM_STATE(WPA_PTK, PTKINITDONE)

> -	if (0 /* IBSS == TRUE */) {
> -		sm->keycount++;
> -		if (sm->keycount == 2) {
> -			wpa_auth_set_eapol(sm->wpa_auth, sm->addr,
> -					   WPA_EAPOL_portValid, 1);
> -		}
> -	} else {
> -		wpa_auth_set_eapol(sm->wpa_auth, sm->addr, WPA_EAPOL_portValid,
> -				   1);
> -	}
> +	wpa_auth_set_eapol(sm->wpa_auth, sm->addr, WPA_EAPOL_portValid,
> +			   1);
> +

Why? That IBSS case is documented there for purpose as a reminder for
eventually completing that behavior as defined in the standard.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list