[PATCH v6 13/15] mesh: do not use offchan mgmt tx on DFS

Jouni Malinen j at w1.fi
Mon Jun 11 10:41:28 PDT 2018


On Thu, May 31, 2018 at 06:02:07PM -0700, peter.oh at bowerswilkins.com wrote:
> Drivers don't allow mesh to use offchannel on management Tx,
> otherwise it will fail and return error.

This commit message is a bit confusing. The proposed change seems to
change offchanok from 1 to 0 only if the channel on which the Action
frame is supposed to be sent out requires DFS. I guess that's wrong as
well.. Shouldn't this be based on the current operating channel of the
mesh BSS rather than the channel where the Action frame might be sent
at?

> @@ -7190,6 +7194,13 @@ static int wpa_driver_nl80211_send_action(struct i802_bss *bss,
>  		os_memset(bss->rand_addr, 0, ETH_ALEN);
>  	}
>  
> +	if (is_mesh_interface(drv->nlmode)) {
> +		modes = nl80211_get_hw_feature_data(bss, &num_modes,
> +						    &flags, &dfs_domain);
> +		if (ieee80211_is_dfs(freq, modes, num_modes))
> +			offchanok = 0;

This freq parameter to ieee80211_is_dfs() is the frequency for the next
Action frame, not of the operating channel.. Isn't the constraint on not
allowing offchannel operations based on the current operating channel
requiring radar detection and as such, not allowing the radio to leave
it?

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list