[PATCH v6 01/15] mesh: factor out mesh join function

Jouni Malinen j at w1.fi
Mon Jun 11 10:12:19 PDT 2018


On Thu, May 31, 2018 at 06:01:55PM -0700, peter.oh at bowerswilkins.com wrote:
> mesh join function consitss of 2 parts which are preparing
> configurations and sending join event to driver.
> Since physical mesh join event could happen either right
> after mesh configuration is done or after CAC is done
> in case of DFS channel is used, factor out the function
> into 2 parts to reduce redundant calls.

What is a "physical mesh join event"?

> diff --git a/wpa_supplicant/mesh.c b/wpa_supplicant/mesh.c

> +void wpas_join_mesh(struct wpa_supplicant *wpa_s)

This function gets renamed within this patch series. Is that really
needed? Please name it once without changing it in the patch series to
avoid unnecessary changes. Furthermore, this function is not used
outside this file after this patch 1/15 or even after patch 4/15 that
renames it to wpas_mesh_complete_cb(). In other words, it should be a
static function and not added as a prototype in mesh.h.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list