[PATCH v5 13/17] mesh: do not allow pri/sec channel switch

Jouni Malinen j at w1.fi
Mon Jun 11 09:55:32 PDT 2018


On Thu, May 31, 2018 at 04:19:21PM -0700, Peter Oh wrote:
> 
> 
> On 05/31/2018 02:07 AM, Jouni Malinen wrote:
> >On Tue, May 29, 2018 at 02:39:17PM -0700, peter.oh at bowerswilkins.com wrote:
> >>We don't want mesh to switch the channel from primary to secondary,
> >>since mesh points are not able to join each other in that case.
> >>diff --git a/wpa_supplicant/mesh.c b/wpa_supplicant/mesh.c
> >>@@ -336,7 +336,10 @@ static int wpa_supplicant_mesh_init(struct wpa_supplicant *wpa_s,
> >>-
> >>+	/* Do not allow primary/secondary channel switch in mesh mode,
> >>+	  * since mesh is not able to establish a physical link for it
> >>+	  */
> >>+	conf->no_pri_sec_switch = 1;
> >What do you mean with "a physical link"? Physical?
> >
> Yes, Physical. the comment will be updated like this in the next revision.
> +       /* Do not allow primary/secondary channel switch in mesh mode,
> +        * since mesh is only able to establish Physical link with peers
> +        * on the same channel.
> +        */

What do you mean with "Physical" in this context? Where is physical
link (or "Physical link"?!) defined? There is no such thing in the IEEE
802.11 standard and it would be better to use terms that people can
understand easily. Maybe just delete "physical"?

That said, this comment is still quite confusing even if "Physical" were
removed. Are you trying to say that a link cannot be established if
different primary channel is used? ".. only able to establishing a link
with peers using the same primary channel"?

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list