[PATCH v2 01/15] mesh: factor out mesh join function

Jouni Malinen j at w1.fi
Fri Apr 13 06:56:46 PDT 2018


On Thu, Apr 12, 2018 at 02:48:58AM -0700, peter.oh at bowerswilkins.com wrote:
> diff --git a/wpa_supplicant/mesh.c b/wpa_supplicant/mesh.c
> @@ -25,6 +25,7 @@
>  #include "mesh_mpm.h"
>  #include "mesh_rsn.h"
>  #include "mesh.h"
> +#include "drivers/driver_nl80211.h"

That's not allowed. wpa_supplicant/* files should not use driver
interface specific header files. mesh.c needs to be generic code that
goes through the driver API in a manner that would work with any
src/drivers/driver_*.c implementation.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list