[PATCH 1/1] macsec: handle missing macsec kernel module

Jouni Malinen j at w1.fi
Sun Sep 10 12:52:14 PDT 2017


On Tue, Aug 22, 2017 at 10:34:19AM +0200, Sabrina Dubroca wrote:
> -------- 8< --------
> From: Sabrina Dubroca <sd at queasysnail.net>
> Date: Tue, 22 Aug 2017 10:25:26 +0200
> Subject: [PATCH] mka: add error handling for secy_init_macsec calls
> 
> secy_init_macsec() can fail (if ->macsec_init fails), and
> ieee802_1x_kay_init() should handle this and not let MKA run any
> further, because nothing is going to work anyway.
> 
> On failure, ieee802_1x_kay_init() must deinit its kay, which will free
> kay->ctx, so ieee802_1x_kay_init callers (only ieee802_1x_alloc_kay_sm)
> must not do it. Before this patch there is a double-free of the ctx
> argument when ieee802_1x_kay_deinit() was called.

Thanks, applied.
 
-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list