[PATCHv7 2/8] FT: New RRB message format

[Jouni Malinen]

On Wed, May 17, 2017 at 10:50:52AM +0200, Nicolas Cavallari wrote:
> This commit and 1/8 breaks the build of wpa_supplicant if one enables
> CONFIG_IEEE80211R_AP, since you forgot to update the wpa_supplicant
> build system.  The build failure look like this:

Hmm.. I did not even remember that CONFIG_IEEE80211R_AP=y was an option
for wpa_supplicant builds.. It does not really make any sense to me,
though, since wpa_supplicant does not support configuration of FT in AP
mode. In other words, I was assuming #ifdef CONFIG_IEEE80211R_AP was in
practice makes the new AP-to-AP protocol changes invisible to
wpa_supplicant.

> ../src/ap/wpa_auth_ft.o: In function `wpa_ft_rrb_encrypt':
> wpa_supplicant/../src/ap/wpa_auth_ft.c:298: undefined reference to
> `aes_siv_encrypt'
> ../src/ap/wpa_auth_ft.o: In function `wpa_ft_rrb_decrypt':
> wpa_supplicant/../src/ap/wpa_auth_ft.c:96: undefined reference to
> `aes_siv_decrypt'
> collect2: error: ld returned 1 exit status
> 
> It is also possible that it does not work at runtime, since you added
> initialization code in hostapd and not in wpa_supplicant. At first
> glance, it seems wpa_supplicant does not have a hostapd_interfaces
> structure, and hapd->iface->interfaces seems to be NULL.
> 
> In my case, CONFIG_IEEE80211R_AP was enabled by accident, so disabling
> it fixes it.  But i think this issue deserve a fix.

I'm tempted to say removing option to enable CONFIG_IEEE80211R_AP for
wpa_supplicant builds would be the solution here.. This code cannot be
reached in such builds since there is no means for configuring AP-to-AP
communication and this FT RRB case.

-- 
Jouni Malinen                                            PGP id EFC895FA