[PATCH 1/5] WNM: Use a dynamically allocated buffer for BTM query and response

Jouni Malinen j at w1.fi
Sat Mar 11 03:45:28 PST 2017


On Wed, Mar 08, 2017 at 02:37:38PM +0200, Andrei Otcheretianski wrote:
> BSS transition management query and response use a large static buffer
> for the frame because the candidate list may require a lot of space.
> However, in most cases the actually used space will be much less than
> the buffer(since the candidate list is short or completely missing).
> 
> Use a dynamically allocated buffer instead and allocate it according
> to the actual space needed.
> 
> while at it, remove unneeded filling of the MAC header in the action
> frames, since wpa_drv_send_action() adds the MAC header anyway.

Thanks, all five patches applied. Though, I removed the dependency on
CONFIG_TESTING_OPTIONS in the wpa_supplicant control interface changes
since there might be a production use case for this as well and the
source code was looking pretty ugly with the #ifdef showing up in the
middle of function parameters.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list