[PATCH] hostapd:Avoid disassociation getting in to a loop by moving timeout_next changes to hostapd_new_assoc_sta()

[Jouni Malinen]

On Wed, Jul 05, 2017 at 09:46:43PM +0530, dheeraj.km at globaledgesoft.com wrote:
> From: dheerajkm <dheeraj.km at globaledgesoft.com>
> 
> Problem:
> STA's connectivity state machine gets into a loop of sending
> disassociation, for previously disassociating STA when no ACK
> is received for Association Response within ap_handle_timer timeout.

Could you please provide more details on what you mean with "loop" here?
Do you mean that there is a continuous stream of Disassociation frames?

> To Fix this issue, move the
>     sta->timeout_next = STA_NULLFUNC;
> from handle_assoc() to hostapd_new_assoc_sta().
> 
> sta->timeout_next is set to STA_NULLFUNC only when Ack is received
> for the Association Response sent out. So if ACK is not received
> within AP_DEAUTH_DELAY, STA is deauthenticated and STA context is
> cleaned up. Due to which there needs to be a new session started
> by STA with AUTH Req.
> ---

Please read the toplevel CONTRIBUTIONS file (*) and resend the patch
with Signed-off-by: line added as described there.


(*) https://w1.fi/cgit/hostap/tree/CONTRIBUTIONS

-- 
Jouni Malinen                                            PGP id EFC895FA