[PATCH 2/3] VHT: Add VHT capabilities checks to IBSS/mesh
masashi.honma at gmail.com
Sun Feb 19 16:34:40 PST 2017
On 2017/02/19 23:11, Jouni Malinen wrote:
>> - return mode->vht_capab != 0;
>> + return !ieee80211ac_cap_check(mode->vht_capab, ssid->vht_capa);
> but this looks problematic. ssid->vht_capa is included only in
> CONFIG_VHT_OVERRIDES=y builds, so this would break common builds. In
> addition, this breaks number of hwsim test cases (e.g.,
> wpas_mesh_open_vht_80p80 ibss_vht_80p80 mesh_open_vht_160) if VHT
> overrides are included. It looks like those test cases end up using only
> 40 MHz channels (HT only?) after this patch.
> ssid->vht_capa is cannot really be used without checking
> ssid->vht_capa_mask. I'm not completely sure I understand what this
> patch is trying to do taken into account ssid->vht_capa is a VHT
> override to allow some capabilities to be disabled for testing purposes;
> not a normal "enable/disable VHT" parameter.
Oh, I understand ssid->vht_capa is for testing functionality.
I will drop this patch.
More information about the Hostap