Error while enabling AP using wpa_supplicant

[Lansky, Dedy]

Hi Jouni,

See attached patch to fix this issue.

Thanks,
 Dedy.

-----Original Message-----
From: Jose Blanquicet [mailto:blanquicet at gmail.com] 
Sent: Friday, February 3, 2017 2:47 PM
To: Lansky, Dedy <dlansky at qti.qualcomm.com>
Cc: Jouni Malinen <j at w1.fi>; MANIEZZO Marco (MM) <marco.maniezzo at magnetimarelli.com>; hostap at lists.infradead.org; Masashi Honma <masashi.honma at gmail.com>; qca_dlansky <qca_dlansky at qca.qualcomm.com>
Subject: Re: Error while enabling AP using wpa_supplicant

On Fri, Feb 3, 2017 at 12:09 PM, Jouni Malinen wrote:
> On Mon, Jan 30, 2017 at 04:09:01PM +0000, Jose Blanquicet wrote:
>> I tried what you suggested and it worked for me:
>>
>> diff --git a/src/drivers/driver_nl80211.c 
>> b/src/drivers/driver_nl80211.c index 6080079..5470312 100644
>> --- a/src/drivers/driver_nl80211.c
>> +++ b/src/drivers/driver_nl80211.c
>> @@ -3783,7 +3783,8 @@ static int wpa_driver_nl80211_set_ap(void *priv,
>>                    beacon_set);
>>         if (beacon_set)
>>                 cmd = NL80211_CMD_SET_BEACON;
>> -       else if (!nl80211_get_wiphy_data_ap(bss))
>> +       else if (!drv->device_ap_sme && !drv->use_monitor &&
>> +                               !nl80211_get_wiphy_data_ap(bss))
>>                 return -ENOBUFS;
>>
>>         wpa_hexdump(MSG_DEBUG, "nl80211: Beacon head",
>>
>> What does Jouni think about this solution?
>
> This looks like the correct thing to do here.
> nl80211_get_wiphy_data_ap() used to be called from
> nl80211_mgmt_subscribe_ap() and that function is within that same 
> !device_ap_sme && !use_monitor case.
>
> Could you please send this patch with a proper commit message and
> Signed-off-by: line so that I can apply it?

It would not be a problem at all but due to I just followed Lansky's suggestion, I was wondering if maybe he would prefer to do it himself.
Lansky, would you?

Regards,

Jose Blanquicet
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-nl80211-fix-error-while-enabling-AP-using-wpa_suppli.patch
Type: application/octet-stream
Size: 1392 bytes
Desc: 0001-nl80211-fix-error-while-enabling-AP-using-wpa_suppli.patch
URL: <http://lists.infradead.org/pipermail/hostap/attachments/20170205/2d8465cb/attachment.obj>