[PATCH] Fixed: Spelling mistakes.

Jouni Malinen j at w1.fi
Fri Sep 30 09:47:01 PDT 2016

On Fri, Sep 30, 2016 at 03:36:36PM +0530, Nishant Chaprana wrote:
> diff --git a/src/drivers/nl80211_copy.h b/src/drivers/nl80211_copy.h

This file is an unmodified copy of include/uapi/linux/nl80211.h in the
kernel tree. As such, all modifications to it need to go through the
Linux kernel. I'm only copying snapshots from there to this file. I'm
dropping the changes to this nl80211_copy.h from the patch. If you want
to get them included here, please submit a similar patch to the Linux
kernel project.

> diff --git a/src/utils/radiotap.c b/src/utils/radiotap.c

Same here. This file is kept close to net/wireless/radiotap.c in the
Linux kernel tree. I'm dropping the change from hostap.git for now and
may consider it in the future if a similar fix gets accepted into the
kernel tree first.

The change in src/crypto/sha512-internal.c is somewhat of a gray area
since the modified function is actually from LibTomCrypt. Anyway, I'm
fine with taking this part in since that code in hostap.git has been
modified for style significantly enough to not claim it to try to be
identical with the LibTomCrypt version.

The other parts are fine and I'll apply them as well.

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list