[PATCH] Revert "nl80211: Remove duplicated check in nl80211_setup_ap()"

Jouni Malinen j at w1.fi
Sat Sep 17 12:51:16 PDT 2016

On Mon, Sep 12, 2016 at 07:28:22PM +0200, Rafał Miłecki wrote:
> This reverts commit 647862eb60c324015ea31293cc052558b5185ca4.
> The second check of device_ap_sme looks like duplicated, but it isn't
> actually. The trick is nl80211_create_monitor_interface may change that
> variable value and the second evaluation may give a different result.
> This definitely isn't a very clear code, but that change caused a
> regression for drivers that:
> 1) Don't report NL80211_ATTR_DEVICE_AP_SME
> 2) Don't support monitor mode
> 3) Don't support subscribing for PROBE_REQ and/or ACTION frames
> like brcmfmac. With such drivers hostapd doesn't start anymore.

Thanks, applied.
Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list