[PATCH 07/18] P2P: Fix possible memory leak in p2p_group_delete
andrei.otcheretianski at intel.com
andrei.otcheretianski at intel.com
Mon Sep 5 07:33:00 PDT 2016
From: Ilan Peer <ilan.peer at intel.com>
In wpas_p2p_group_delete() free the pointer earlier, as the function
might return early.
Signed-off-by: Ilan Peer <ilan.peer at intel.com>
---
wpa_supplicant/p2p_supplicant.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/wpa_supplicant/p2p_supplicant.c b/wpa_supplicant/p2p_supplicant.c
index c138413..21b6213 100644
--- a/wpa_supplicant/p2p_supplicant.c
+++ b/wpa_supplicant/p2p_supplicant.c
@@ -929,6 +929,10 @@ static int wpas_p2p_group_delete(struct wpa_supplicant *wpa_s,
eloop_cancel_timeout(wpas_p2p_move_go, wpa_s, NULL);
eloop_cancel_timeout(wpas_p2p_reconsider_moving_go, wpa_s, NULL);
+ os_free(wpa_s->p2p_group_common_freqs);
+ wpa_s->p2p_group_common_freqs = NULL;
+ wpa_s->p2p_group_common_freqs_num = 0;
+
/*
* Make sure wait for the first client does not remain active after the
* group has been removed.
@@ -968,10 +972,6 @@ static int wpas_p2p_group_delete(struct wpa_supplicant *wpa_s,
os_free(wpa_s->go_params);
wpa_s->go_params = NULL;
- os_free(wpa_s->p2p_group_common_freqs);
- wpa_s->p2p_group_common_freqs = NULL;
- wpa_s->p2p_group_common_freqs_num = 0;
-
wpa_s->waiting_presence_resp = 0;
wpa_printf(MSG_DEBUG, "P2P: Remove temporary group network");
--
1.9.1
More information about the Hostap
mailing list