[PATCH] mka: fix getting capabilities from the driver

Jouni Malinen j at w1.fi
Sat Nov 19 14:41:29 PST 2016

On Tue, Nov 15, 2016 at 06:06:23PM +0100, Sabrina Dubroca wrote:
> In commit a25e4efc9e42 ("mka: Add driver op to get macsec capabilities")
> I added some code to check the driver's capabilites. This commit has two
> problems:
>  - wrong enum type set in kay->macsec_confidentiality
>  - ignores that drivers could report MACSEC_CAP_NOT_IMPLEMENTED, in
>    which case the MKA would claim that MACsec is supported.
> Fix this by interpreting MACSEC_CAP_NOT_IMPLEMENTED in the same way as a
> DO_NOT_SECURE policy, and set the correct value in
> kay->macsec_confidentiality.

Thanks, applied.
Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list