[PATCH] Fix for interface names parameter ignores subsequent parameters

[Sam Tannous]

Hi Jouni,

Thanks for the clarification.  I did misunderstand the -i option
(wishful thinking, I guess ;-)).

For our purposes, we have lots of wired interfaces  (under 60 wired interfaces)
all using the same config file with the same radius parameters.  So my
temporary patch (just starting hostapd with -i foo1,foo2,foo3...
radiusForAll.conf) seems to be working.

Ideally, I would like to just have *one* config file without the -i option
and just specify a new "interfaces" (note the plural) option
("interfaces=swp1,swp2,...swpN") as the first line.   Our CLI
can create this file and then restart/reload hostapd as needed.

(The other features we plan to add are adding netlink awareness to the
wired driver and
adding an removing (layer2) filtering based on netlink messages and
authentication
status of particular stations.  I've seen some filtering patches where
this has been tried
in the past. The plan is to use the linux tc filtering rules called
from hostapd.

Thanks,
Sam Tannous
Cumulus Networks


On Sat, Nov 19, 2016 at 3:26 PM, Jouni Malinen <j at w1.fi> wrote:
> On Mon, Nov 07, 2016 at 01:43:36PM -0500, Sam Tannous wrote:
>> When using -i to specify one or more comma separated interfaces
>> (that all use the same config file), we also need to change
>> the loop parameters (interface.count) so that all the interfaces get
>> initialized.  Also, we need to make sure that all the
>> hostapd_interface_init()
>> calls are made with the same config filename.
>>
>> This patch fixes hostapd/main.c to correct the interface count
>> and use of the one config file in the interface initialization call.
>
> I don't think this is the way this argument was supposed to work. In
> other words, it is more flexible and allows some interfaces to use
> different configuration files as needed. In any case, there would need
> to be a configuration file listed for each interface on the command line
> even if they were to be the same file for more than one interface. For
> example:
>
> hostapd -i wlan0,wlan1,wlan2 a.conf b.conf a.conf
>
> This would use a.conf configuration file for both wlan0 and wlan2 while
> b.conf is used for wlan1.
>
> --
> Jouni Malinen                                            PGP id EFC895FA



-- 
Sam Tannous
Engineering
Cumulus Networks®
+1 650 383 6700 x 1106
www.cumulusnetworks.com

Evaluate Cumulus® Linux®
https://cumulusnetworks.com/product/secure/evaluate/

Become a Partner
http://cumulusnetworks.com/partners/become-a-partner/