[PATCH] wpa_cli: Run action file in case of an AP event

Jouni Malinen j at w1.fi
Fri May 27 02:04:51 PDT 2016


On Wed, May 25, 2016 at 09:08:11AM +0200, Jörg Krause wrote:
> I would like to pass more events, e.g. ASSOC-REJECT, to the action
> script. Do you have any concerns about which events are passed?

I do have some concern based on what is actually included in the event
contents, i.e., whether it is something that can be controlled by remote
devices. This is an area that is inconveniently easy to do in a manner
that results in security vulnerabilities.

> Currently, the events are passed in two different ways: Pass a
> shortened string like "CONNECTED" and "DISCONNECTED" for CTRL_EVENT_*
> or pass a full string for all other events.
> 
> As ASSOC-REJECT is of type CTRL_EVENT_* too, do you prefer to pass the
> string "ASSOC-REJECT" or CTRL_EVENT_ASSOC_REJECT, e.g.
> 
>     wpa_cli_exec(action_file, ifname, "ASSOC-REJECT");
> 
> OR
> 
>     wpa_cli_exec(action_file, ifname, CTRL_EVENT_ASSOC_REJECT);

I have no strong preference on that front.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list