[PATCH] OpenSSL: BoringSSL has SSL_get_client_random, etc.

David Benjamin davidben at google.com
Wed May 11 14:08:56 PDT 2016

On Tue, May 10, 2016 at 12:48 PM, Jouni Malinen <j at w1.fi> wrote:
>> I can start a BORINGSSL_API_VERSION counter and roll that into AOSP
>> now. This will be a random meaningless number except we promise it
>> will only increase and we'll probably increment it at points vaguely
>> corresponding with additions or changes in the API, wherever it ends
>> up convenient to do so. :-) Then this patch will be updated to be
>> defined(BORINGSSL_API_VERSION). In future we'd do
>> BORINGSSL_API_VERSION > whatever. And then you all can figure out how
>> far back it should go. (For my part, I want to minimize your burden,
>> so I would encourage you need to retain support for versions older
>> than you need, but it sounds like your master branch cares about more
>> Android releases than I thought.)
>> Does that sound reasonable?
> Yes, this would work fine for me and the updated patch you sent looked
> good as well.
> And as a side note, most of my automated testing is on non-Android
> platforms with Linux, so it is a significant benefit to be able to build
> the latest wpa_supplicant with number of snapshots of BoringSSL on
> x86_64 Linux. This allows both the current master branch of BoringSSL
> (i.e., what to expect to see in the products in the future) and various
> releases version (e.g., based on Android release tags) being used to run
> through the mac80211_hwsim test runs for regression testing and to come
> up with new test cases to verify issues that may show up in this area.

Sounds good. I'll bump BORINGSSL_API_VERSION where relevant for you
all in future then. I'll leave cleaning up any old codepaths to you,
since I don't know how far back you want to go.

Is there anything else you need from me w.r.t. the updated patch, or
is it good to go? external/boringssl on AOSP master is now updated
past the point where BORINGSSL_API_VERSION is defined, so that should
be all good.


More information about the Hostap mailing list